Use external GraphQL client for smoke tests #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardehrenfried
force-pushed
the
graphql-smoke-tests
branch
from
c45bc68
to
3952618
Compare
leonardehrenfried
force-pushed
the
graphql-smoke-tests
branch
from
c5820fa
to
aa7ed7d
Compare
leonardehrenfried
force-pushed
the
graphql-smoke-tests
branch
from
c40faab
to
0214421
Compare
miles-grant-ibigroup
approved these changes
Aug 10, 2023
binh-dam-ibigroup
approved these changes
Aug 16, 2023
|
|
||
| @Test | ||
| public void regularRouteFromCentralAtlantaToPowderSprings() { | ||
| Set<String> modes = Set.of("TRANSIT", "WALK"); | ||
| var modes = Set.of(TRANSIT, WALK); | ||
| SmokeTest.basicRouteTest( | ||
| new SmokeTestRequest(nearGeorgiaStateStation, powderSpringsInsideFlexZone1, modes), | ||
| List.of("WALK", "SUBWAY", "WALK", "BUS", "WALK", "BUS", "WALK") |
There was a problem hiding this comment.
The expected modes could eventually be moved to use LegMode directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since GraphQL is now the main API that the IBI frontend use, I'm switching the SmokeTests to also use GraphQL.
It does this by using a separate client that I wrote for another project.